Skip to content

Validate stream and window update ranges #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Validate stream and window update ranges #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/http/2/framer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,10 @@ def common_header(frame, buffer:)

stream_id = frame.fetch(:stream, 0)

raise CompressionError, "Stream ID (#{stream_id}) is too large" if stream_id > MAX_STREAM_ID
raise CompressionError, "Stream ID (#{stream_id}) is outside the valid range" unless stream_id.between?(0, MAX_STREAM_ID)

if type == :window_update && frame[:increment] > MAX_WINDOWINC
raise CompressionError, "Window increment (#{frame[:increment]}) is too large"
if type == :window_update && !frame[:increment].between?(1, MAX_WINDOWINC)
raise CompressionError, "Window increment (#{frame[:increment]}) is outside the valid range"
end

flags = frame[:flags]
Expand Down