Skip to content

feat: judge golden trace and variance stats - #111

Merged
igmarin merged 1 commit into
mainfrom
feat/judge-golden-traces
Sep 14, 2026
Merged

igmarin merged 1 commit into
mainfrom
feat/judge-golden-traces

Conversation

@igmarin

@igmarin igmarin commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Why

ROADMAP item 4. Judge scores had no golden fixture and no way to talk about inter-run spread. Deltas are not product truth without that.

What

  • test/fixtures/judge_traces/canonical.json — 5 canonical dimensions, total 80
  • Judge::Response must keep parsing that fixture
  • Judge::Variance.call(totals:) — sample mean, stddev, spread (n < 2 → nils)
  • Verdict formula unchanged
  • ROADMAP: items 2–3 marked shipped; item 4 first slice

Proof

bundle exec ruby -Itest test/judge/variance_test.rb
# 2 runs, 0 failures

bundle exec ruby -Itest test/judge/golden_trace_test.rb
# 1 run, 0 failures

Not in this PR: live --repeat recording of judge totals.

Lock parser behavior on a canonical 5-dimension fixture. Add
Judge::Variance for sample mean/stddev/spread. Do not change verdict math.
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: bddb04ee-6d16-4de0-83b3-73d5a4f69a34

📥 Commits

Reviewing files that changed from the base of the PR and between b0bdef7 and 333aad0.

📒 Files selected for processing (8)
  • CHANGELOG.md
  • ROADMAP.md
  • lib/skill_bench.rb
  • lib/skill_bench/judge/README.md
  • lib/skill_bench/judge/variance.rb
  • test/fixtures/judge_traces/canonical.json
  • test/judge/golden_trace_test.rb
  • test/judge/variance_test.rb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@igmarin
igmarin merged commit 2d39e7d into main Sep 14, 2026
6 checks passed
@igmarin
igmarin deleted the feat/judge-golden-traces branch September 14, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant