fix: make legacy dataset provenance explicit#723
Open
shawcharles wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Thanks. I pushed a small review-response follow-up in Changes since the initial PR:
Validation:
From my side this is ready for maintainer review / CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #722.
Summary
mpdtaURLs with immutable commit-pinned sources and verify every downloaded or cached byte sequence against a pinned SHA-256load_divorce_laws()explicitly warn and return its existing synthetic fallback because no verified source reproduces its composite public schema without additional analytical choicesdf.attrs["source"]; expected source failures emit oneUserWarningcontainingSYNTHETICand usesource="synthetic_fallback"The verified artefacts are:
public.datat commit07bc929f1d6552db117bd27a7cf0d881d16e9494, SHA-25604bde0cad5540980f32ce099c6dad369e2f05494698071d8a65b3e1cbe9ca53acastle.dtaat commitca4279a87a6f0759f6b6f02841a53bdd68e27d3c, SHA-256804633c161827b6c0824f86f239046386d1a8266a866f83bf5ddb2aa762a5f29mpdta.csvat commit7ad707385354cb3924b8da94ef7e62a76bf55a4d, SHA-2562283bea1221a152420f98dfa20f633c5d054ea51d881115c8cd702a97bcd3167mpdtais now the genuine packaged example data. The Wooldridge/Callaway estimator cross-check remains on the pre-existing controlled synthetic DGP so that it tests estimators rather than source availability or a different finite-sample estimand.Validation
python -m pytest tests/test_datasets.py -q(Python 3.12): 69 passedpython3.9 -m pytest tests/test_datasets.py -qin an isolated Python 3.9.25 environment: 69 passedpython -m ruff checkon all touched Python filespython -m black --checkon all touched Python filespython -m mypy --follow-imports=skip diff_diff/datasets.pyAll tests are deterministic and required CI does not depend on live network access.