Keep null-conditional LINQ chains in method syntax - #3969
Merged
siegfriedpammer merged 2 commits intoAug 10, 2026
Merged
Conversation
Query syntax cannot preserve a null-conditional receiver that lifts a value type. Detect null conditionals through the LINQ receiver chain before introducing query syntax. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0dd407b6-9410-48df-add5-761ca4a8dec0
siegfriedpammer
force-pushed
the
fix-null-conditional-query-syntax
branch
from
August 10, 2026 16:17
107e205 to
3a8e7de
Compare
A query source can be reached through an indexer as well as through a member access or a call: `holder?[0].Where(...).Select(...)` puts an IndexerExpression between the LINQ call and the `?.`. The receiver walk stopped there, so query syntax was still introduced over a source the conditional access had lifted to a nullable value type, and the output failed to compile with CS1936 - the same way as the case that was reported, one node kind further along. IndexerExpression.Target is nullable where MemberReferenceExpression's and InvocationExpression's are not, so only that arm needs to match on the target. Assisted-by: Claude:claude-opus-5[1m]:Claude Code
siegfriedpammer
force-pushed
the
fix-null-conditional-query-syntax
branch
from
August 10, 2026 17:32
47daab9 to
4a2afbb
Compare
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr: Keep LINQ method syntax when its receiver chain contains a null-conditional access.
Fixes #3968
Problem
IntroduceQueryExpressionsonly checks the immediate LINQ receiver for?.. A chainedWhere(...).Select(...)can therefore be converted to query syntax even when its source contains a null-conditional access over a value type.The query source is then nullable and does not implement the query pattern.
Solution
Make
IsNullConditionalinspect the member and invocation receiver chain before introducing query syntax.