Repository navigation
Add launchd-managed background shares - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An agent-launched
remote-installer sharecould be killed when the temporary command session ended, leaving the install URL visible while the local origin and tunnel were already gone. The existing--timeoutonly controlled the worker after it had started; it did not give the process a lifetime outside the agent command session.What changed
share --background, which registers a native worker with the user'slaunchdGUI domain and waits for the origin and tunnel to become ready before returning.status,logs, andstopcommands for managed share lifecycle control.SIGTERMhandling.&, ornohupfor links that must survive an agent turn.Validation
cargo fmt -- --checkcargo test --all-targets— 158 tests passed (119 library, 18 CLI, 3 Android, 6 availability, 3 download progress, 5 OTA, 4 range-request tests).cargo clippy --all-targets -- -D warningsSIGKILLof the worker resulted in launchd process-group cleanup of the tunnel child and the session reported failure.