Fix SQLAlchemy 2.0 FOR UPDATE AttributeError and reserved word quoting - #200
Open
bchoudhary6415 wants to merge 1 commit into
Open
bchoudhary6415 wants to merge 1 commit into
bchoudhary6415 wants to merge 1 commit into
Conversation
Signed-off-by: Balram Choudhary <bchoudhary@rocketsoftware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves two issues in ibm_db_sa:
FOR UPDATE AttributeError on SQLAlchemy 2.0.x
for_update_clause()used the removedselect.for_updateattribute,raising "'Select' object has no attribute 'for_update'".
modern versions use
select._for_update_arg, legacy versions fallback to
select.for_update.sqlalchemy>=1.3.5,<2.1in setup.py to stay within thesupported range.
Reserved word quoting
quote_identifier()override that uppercases onlycase-insensitive (lowercase) normalized identifiers to match Db2's
catalog, while preserving explicitly quoted (
quote=True) andmixed-case identifiers so case-sensitive schema/table/column names
still resolve correctly.