Skip to content

Release/9.1 to master - #11861

Merged
sensei-hacker merged 2 commits into
masterfrom
release/9.1
Sep 3, 2026
Merged

Release/9.1 to master#11861
sensei-hacker merged 2 commits into
masterfrom
release/9.1

Conversation

@sensei-hacker

Copy link
Copy Markdown
Member

No description provided.

Backport of #11856 (merged to maintenance-10.x) to release/9.1. The PR
Test Builds workflow is triggered by workflow_run, which executes from the
default branch (master); master is fed from release/9.1, so this must land
here (and ride 9.1 -> master) for PR test-build releases to attach .uf2.

- ci.yml: upload ./build/*.uf2 alongside *.hex in the firmware matrix and
  single-target jobs (upload-artifact unions the globs and defaults
  if-no-files-found: warn, so jobs without a .uf2 are unaffected).
- pr-test-builds.yml: attach hexes/*.uf2 to the PR test-build release when
  present (guarded so PRs with no .uf2 don't pass a literal unmatched glob),
  and mention it in the release notes.

The .uf2 itself is produced by RP2350 targets via the in-tree elf2uf2.py
(python3, always on runners); no picotool dependency.
…ets-91

ci: publish .uf2 test builds (RP2350) alongside .hex in PR releases
@qodo-code-review

Copy link
Copy Markdown
Contributor

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@sensei-hacker
sensei-hacker merged commit 35b7d86 into master Sep 3, 2026
13 checks passed
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Publish UF2 firmware in PR test-build releases

✨ Enhancement ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Uploads optional UF2 firmware alongside HEX artifacts from matrix and single-target builds.
• Publishes available UF2 files in PR test-build releases for BOOTSEL flashing.
• Preserves release publishing for targets producing only HEX files.
Diagram

graph TD
  A["Firmware Build"] --> B["HEX Output"] --> D["CI Artifacts"] --> E["PR Publisher"] --> F["Test Release"]
  A --> C["UF2 Output"] --> D
Loading
High-Level Assessment

The current approach is appropriate: reuse the existing artifact and release pipeline while conditionally appending UF2 assets. An unconditional UF2 glob was reasonably avoided because targets without UF2 output could pass an invalid literal path to the GitHub CLI.

Files changed (2) +15 / -4

Enhancement (1) +9 / -2
pr-test-builds.ymlAttach optional UF2 images to PR releases +9/-2

Attach optional UF2 images to PR releases

• Builds an explicit release asset list containing all HEX files and any available UF2 files. Release notes now explain UF2 availability and BOOTSEL drag-and-drop flashing.

.github/workflows/pr-test-builds.yml

Other (1) +6 / -2
ci.ymlUpload UF2 files with firmware build artifacts +6/-2

Upload UF2 files with firmware build artifacts

• Adds UF2 files to artifact uploads for both matrix and single-target firmware jobs. Missing UF2 outputs remain non-fatal under the upload action's default behavior.

.github/workflows/ci.yml

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant