Skip to content

ci: publish .uf2 test builds (RP2350) alongside .hex in PR releases #11860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sensei-hacker merged 1 commit into from
Sep 3, 2026
+15 −4
Merged

ci: publish .uf2 test builds (RP2350) alongside .hex in PR releases #11860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: matrix-${{ env.BUILD_NAME }}.${{ matrix.id }}
path: ./build/*.hex
path: |
./build/*.hex
./build/*.uf2

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Sep 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Uf2 assets are never produced 🐞 Bug ≡ Correctness

The new upload globs depend on build/*.uf2, but this branch contains no RP2350_PICO target,
elf2uf2.py, or CMake rule that emits UF2 output. Every build therefore leaves these globs
unmatched, and PR releases never attach the advertised UF2 image.
Agent Prompt 
## Issue description
The CI and release workflows now publish `build/*.uf2`, but this branch has no RP2350 target or conversion rule that creates such files. Backport or implement the prerequisite RP2350 UF2 build support so both full-matrix and single-target builds emit the expected root-level UF2 artifact.

## Issue Context
Matrix builds run the `ci` target, which only builds registered release targets, while single-target builds invoke registered target names directly. Existing post-link conversion support emits HEX and BIN only, and the repository has no `RP2350_PICO` definition or `elf2uf2.py` implementation.

## Fix Focus Areas
- .github/workflows/ci.yml[122-132]
- .github/workflows/ci.yml[164-174]
- cmake/ci.cmake[4-15]
- cmake/main.cmake[93-108]
- cmake/stm32.cmake[195-213]
- cmake/stm32.cmake[262-268]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

retention-days: 1
- name: Upload size report
uses: actions/upload-artifact@v4
Expand Down Expand Up @@ -167,7 +169,9 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: matrix-${{ env.BUILD_NAME }}.single
path: ./build/*.hex
path: |
./build/*.hex
./build/*.uf2
retention-days: 1
- name: Upload size report
uses: actions/upload-artifact@v4
Expand Down
11 changes: 9 additions & 2 deletions .github/workflows/pr-test-builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,17 @@ jobs:
PR_URL="https://github.com/${REPO}/pull/${PR_NUMBER}"
printf '%s\n\n%s\n\n%s\n' \
"Test build for [PR #${PR_NUMBER}](${PR_URL}) — commit \`${SHORT_SHA}\`" \
"**${HEX_COUNT} targets built.** Find your board's \`.hex\` file by name (e.g. \`MATEKF405SE.hex\`)." \
"**${HEX_COUNT} targets built.** Find your board's \`.hex\` file by name (e.g. \`MATEKF405SE.hex\`); targets that also publish a \`.uf2\` (e.g. \`RP2350_PICO\`) attach it alongside for BOOTSEL drag-and-drop flashing." \
"> Development build for testing only. Use Full Chip Erase when flashing." \
> release-notes.md
gh release create "pr-${PR_NUMBER}" hexes/*.hex \
# Attach .uf2 images when present (RP2350 targets publish them for
# BOOTSEL drag-and-drop). Build an explicit asset list so a PR that
# produced no .uf2 doesn't pass a literal unmatched glob to gh.
ASSETS=(hexes/*.hex)
if compgen -G "hexes/*.uf2" > /dev/null; then
ASSETS+=(hexes/*.uf2)
fi
gh release create "pr-${PR_NUMBER}" "${ASSETS[@]}" \
--repo iNavFlight/pr-test-builds \
--prerelease \
--title "PR #${PR_NUMBER} (${SHORT_SHA})" \
Expand Down
Loading