Test check master ahead of 9? - #11859
Conversation
Release/9.1 to master
Release/9.1 to master
Release/9.1 to master. Github action size baseline, ram/flash guidance
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Code Review by Qodo
1. Giantec flash IDs unreachable
|
| #define JEDEC_ID_Giantec_GT25Q64EZ 0x1C7117 | ||
| #define JEDEC_ID_Giantec_GT25Q128EZ 0x1C7118 |
There was a problem hiding this comment.
1. Giantec flash ids unreachable 🐞 Bug ≡ Correctness
The new GT25Q64EZ and GT25Q128EZ IDs are declared in the W25N NAND driver but have no cases in w25n_detect(), so both IDs take the unsupported-device path and fail initialization. These GT25Q NOR devices should instead be registered in the M25P16-compatible device table.
Agent Prompt
## Issue description
The newly added Giantec GT25Q IDs are declared in the W25N NAND driver, but its detector does not handle them. Register these NOR devices in the M25P16-compatible geometry table and remove the unused W25N declarations.
## Issue Context
`w25n_detect()` only configures known NAND devices and rejects every other ID. The GT25Q devices require the NOR flash implementation and correct geometry values.
## Fix Focus Areas
- src/main/drivers/flash_w25n.c[127-132]
- src/main/drivers/flash_w25n.c[239-274]
- src/main/drivers/flash_m25p16.c[87-126]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| if (isEstimatedWindSpeedValid()) { | ||
| windSpeed = (uint16_t)getEstimatedHorizontalWindSpeed(&windAngle); | ||
| windFlags = 1; |
There was a problem hiding this comment.
2. Unbounded wind serialization 🐞 Bug ≡ Correctness
The MSP wind handler directly converts an unconstrained floating-point wind magnitude to uint16_t; estimates above 65535 cm/s are outside the destination type's range and yield an invalid or implementation-dependent wire value. Saturate and validate the estimate before serialization.
Agent Prompt
## Issue description
The new MSP wind response casts an unconstrained floating-point speed directly to `uint16_t`. Validate that the result is finite and clamp it to the protocol field's representable range before conversion.
## Issue Context
The estimator returns a floating-point magnitude in cm/s and does not impose the `uint16_t` wire-format limit. Preserve the existing validity flag and angle behavior while making serialization deterministic.
## Fix Focus Areas
- src/main/fc/fc_msp.c[1603-1615]
- src/main/flight/wind_estimator.c[69-82]
- src/main/flight/wind_estimator.c[154-185]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
PR Summary by QodoPrepare INAV 9.1 with new targets, fixes, and size-report CI
AI Description
Diagram
High-Level Assessment
Files changed (148)
|
Release/9.1 to master
No description provided.