ci: publish .uf2 test builds (RP2350) alongside .hex in PR releases

[sensei-hacker]

Summary

Backport of #11856 (already merged to maintenance-10.x) to maintenance-9.x.

The PR Test Builds workflow is triggered by workflow_run, which executes from the default branch (master). Since master is fed from maintenance-9.x, this change must land on 9.x (and then ride 9.x → master) before PR test-build releases can attach .uf2 images.

RP2350_PICO targets (see #11854) generate a .uf2 for BOOTSEL drag-and-drop flashing in addition to the .hex that pr-test-builds publishes.

Changes

.github/workflows/ci.yml

• Upload ./build/*.uf2 alongside ./build/*.hex in the firmware matrix and single-target jobs (multiline path; upload-artifact@v4 unions the globs and defaults if-no-files-found: warn, so jobs without a .uf2 are unaffected).

.github/workflows/pr-test-builds.yml

• Attach hexes/*.uf2 to the PR test-build release when present, guarded so PRs without a .uf2 don't pass a literal unmatched glob to gh release create.
• Mention .uf2 in the release notes.

The .uf2 is produced by RP2350 targets via the in-tree elf2uf2.py (python3, always on runners) — no picotool / apt dependency (picotool isn't packaged in Ubuntu 24.04).

Notes

• Byte-identical to the maintenance-10.x version of the change for pr-test-builds.yml; ci.yml carries only the .uf2 upload-glob hunks (9.x lacks the size-report steps that 10.x has).
• Safe on branches without a .uf2-producing target: upload glob matches nothing (warn-only), release asset list stays .hex-only.

[qodo-code-review]

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Publish RP2350 UF2 Assets in PR Test Releases

✨ Enhancement ⚙️ Configuration changes 🕐 10-20 Minutes

AI Description

• Upload optional UF2 firmware alongside HEX artifacts from matrix and single-target CI builds.
• Attach available UF2 images to PR test releases without breaking HEX-only builds.
• Explain BOOTSEL-compatible UF2 downloads in release notes.

Diagram

graph TD
  A["Firmware build"] --> B["HEX and UF2"] --> C["Artifact upload"] --> D["PR publisher"] --> E{"UF2 present?"}
  E -- Yes --> F["Release assets"] --> G["Tester download"]
  E -- No --> F

Loading

High-Level Assessment

The current approach is appropriate: it extends the existing artifact pipeline without new dependencies and explicitly guards optional UF2 assets before invoking GitHub CLI. Shell glob options or separate release-upload commands would be less explicit or add unnecessary release operations.

Files changed (2) +15 / -4

Enhancement (1) +9 / -2

pr-test-builds.ymlPublish optional UF2 files in PR test releases +9/-2

Publish optional UF2 files in PR test releases

• Builds an explicit release asset array and appends UF2 files only when present, preventing unmatched globs in HEX-only builds. Release notes now describe RP2350 BOOTSEL-compatible downloads.

.github/workflows/pr-test-builds.yml

Other (1) +6 / -2

ci.ymlUpload UF2 outputs from firmware build jobs +6/-2

Upload UF2 outputs from firmware build jobs

• Adds UF2 output globs to both matrix and single-target artifact uploads. Targets producing only HEX files remain unaffected because missing optional matches are warn-only.

.github/workflows/ci.yml

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[sensei-hacker]

Closing — target should be release/9.1 (master is fed from release/9.1, not maintenance-9.x); reopening against release/9.1.