Skip to content

Update JavaScript guest tooling - #178

Open
jsturtevant wants to merge 6 commits into
mainfrom
jsturtevant-consolidate-javascript-updates
Open

Update JavaScript guest tooling#178
jsturtevant wants to merge 6 commits into
mainfrom
jsturtevant-consolidate-javascript-updates

Conversation

@jsturtevant

Copy link
Copy Markdown
Contributor

Summary

  • update @bytecodealliance/componentize-js from 0.21.0 to 0.22.0
  • update @bytecodealliance/jco from 1.24.3 to 1.27.0
  • regenerate the coherent npm lockfile for the combined update
  • confirm the JavaScript guest still preserves required WASI filesystem imports and builds to Wasm and AOT

Supersedes #171 and #174.

Validation

  • just wasm js-guest-build
  • just wasm guest-compile-wit
  • git diff --check

Full just build, just fmt, just fmt-check, and just wasm examples were attempted locally. Python tooling downloads from files.pythonhosted.org repeatedly failed with external TLS HandshakeFailure errors; no tests or dependency policies were weakened.

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@jsturtevant
jsturtevant force-pushed the jsturtevant-consolidate-javascript-updates branch from a46c2cc to 88b631c Compare August 13, 2026 23:00
@jsturtevant
jsturtevant requested a lite review from Copilot August 14, 2026 21:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the JavaScript guest’s build/tooling dependencies (@bytecodealliance/componentize-js and @bytecodealliance/jco) and regenerates the npm lockfile to reflect the new transitive dependency graph, supporting continued Wasm/AOT guest builds.

Changes:

  • Bump @bytecodealliance/componentize-js to ^0.22.0 and @bytecodealliance/jco to ^1.27.0.
  • Regenerate package-lock.json for the combined dependency update (including new transitive tooling such as rolldown / oxc-minify).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/wasm_sandbox/guests/javascript/package.json Updates JS guest devDependency versions for the updated guest tooling.
src/wasm_sandbox/guests/javascript/package-lock.json Regenerates the npm lockfile to match the updated tooling dependency graph.
Files not reviewed (1)
  • src/wasm_sandbox/guests/javascript/package-lock.json: Generated file
Suppressed comments (1)

src/wasm_sandbox/guests/javascript/package-lock.json:205

  • package-lock.json now pins @bytecodealliance/jco to a Visual Studio package feed URL (ms-feed-*.pkgs.visualstudio.com) with a SHA-1 integrity value. This can break npm ci for users without that feed and reduces hash strength compared to typical SHA-512 SRI from registry.npmjs.org. Please regenerate the lockfile with a portable registry configuration.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/wasm_sandbox/guests/javascript/package-lock.json
Comment thread src/wasm_sandbox/guests/javascript/package.json
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Comment thread .github/workflows/regenerate-js-lock.yml Fixed
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants