ci: add extra final step to aggregate matrix results#44
Open
shadaj wants to merge 1 commit into
Open
Conversation
Otherwise, when intermediate steps are skipped due to no changes, the PR hangs in a state where it is waiting for expected checks.
Deploying infinity with
|
| Latest commit: |
9d6a2b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://66ef5bf3.infinity-dc7.pages.dev |
| Branch Preview URL: | https://ci-final-step.infinity-dc7.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR adds an always-running “aggregator” job to produce a single, deterministic check result for the full test matrix, even when the matrix job is skipped (e.g., due to the skip-duplicate-actions gate). This helps avoid PRs getting stuck “waiting for expected checks” when matrix jobs don’t execute.
Changes:
- Add a new
test-alljob that always runs aftertestand convertsneeds.test.resultinto a pass/fail outcome. - Treat
successandskippedas passing outcomes for the aggregate check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, when intermediate steps are skipped due to no changes, the PR
hangs in a state where it is waiting for expected checks.