fix: subscription events inherit pretty tool call display_as#40
Draft
shadaj wants to merge 1 commit into
Draft
Conversation
Deploying infinity with
|
| Latest commit: |
86a56d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2fa1ccf2.infinity-dc7.pages.dev |
| Branch Preview URL: | https://sandbox-23067c05-3f9d-43fb-a.infinity-dc7.pages.dev |
In both the live processing path (batch_processor.rs) and the history replay path (display.rs), subscription events now use the `display_as` string from the originating `InfinityMessage::ToolCall` when available, falling back to `name(args)` only when no pretty display was computed. The history lookup iterates in reverse since the subscription tool call is typically near the end of the conversation. Added a unit test (`subscription_event_uses_display_as`) that seeds history with a tool call + result (subscription started), then sends a synthetic subscription event and asserts the display uses the pretty `display_as` string rather than raw `name(args)`. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #40
shadaj
force-pushed
the
sandbox-23067c05-3f9d-43fb-a5a5-f3b8eaf7aa4e
branch
from
2b0cc07 to
86a56d5
Compare
shadaj
commented
Jun 27, 2026
| let orig_call = current_history.get_history().into_iter().find(|h| { | ||
| if let Message::Assistant { content, .. } = h | ||
| && let AssistantContent::ToolCall(c) = content.first() | ||
| let orig_call = current_history.history.borrow().iter().rev().find_map(|m| { |
Member
Author
There was a problem hiding this comment.
This might not be correct if the tool call is from before a compaction point?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In both the live processing path (batch_processor.rs) and the history
replay path (display.rs), subscription events now use the
display_asstring from the originating
InfinityMessage::ToolCallwhen available,falling back to
name(args)only when no pretty display was computed.The history lookup iterates in reverse since the subscription tool call
is typically near the end of the conversation.
Added a unit test (
subscription_event_uses_display_as) that seedshistory with a tool call + result (subscription started), then sends a
synthetic subscription event and asserts the display uses the pretty
display_asstring rather than rawname(args).Co-authored-by: Infinity 🤖 infinity@hydro.run