docs(args): fix stale cap literals missed by #1056#1064
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughFour single-line fixes across two pairs of mirrored header files in the ChangesComment and Error String Corrections
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hw-native-sys#1056 raised CORE_MAX_TENSOR_ARGS to 32 and lowered CORE_MAX_SCALAR_ARGS to 16. It updated the scalar-limit error strings but left two stale literals behind: - pto_types.h: the tensor-limit error string still read "exceeds MAX_TENSOR_ARGS=16"; the cap is now 32 (a2a3 + a5). - pto_runtime2_types.h: the PTO2TaskPayload::init memcpy comment said "Both arrays are 1024B" (dates from a 128-scalar cap). The scalar arrays are now MAX_SCALAR_ARGS * 8 = 128B (a2a3 + a5). Comment/string only; no ABI or behavior change.
d03deca to
1795a8e
Compare
What
Fixes two stale cap literals left behind by #1056 (which raised
CORE_MAX_TENSOR_ARGS16→32 and loweredCORE_MAX_SCALAR_ARGS32→16).#1056 updated the scalar-limit error strings but missed:
pto_types.h(a2a3 + a5): the tensor-limit error string still read"exceeds MAX_TENSOR_ARGS=16". The cap is now 32 — a user who hitsthe tensor-arg cap would otherwise get a misleading message.
pto_runtime2_types.h(a2a3 + a5): thePTO2TaskPayload::initmemcpy comment said
"Both arrays are 1024B"(dates from an old128-scalar cap). The scalar arrays are now
MAX_SCALAR_ARGS * 8=128B.
Comment/string only — no ABI or behavior change.
These literals are only correct on top of #1056's cap change. On
main,CORE_MAX_TENSOR_ARGSis still 16 and the scalar arrays are 256B,so the current text is correct there. This branch is stacked on #1056:
Update: raise CORE_MAX_TENSOR_ARGS to 32, lower scalars to 16 #1056 lands, rebasing reduces it to the 4-line doc fix here.