Repository navigation
Fix Metrics.drop corpus aggregation to use mean instead of max - #1422
Open
salignatmoandal wants to merge 1 commit into
Open
salignatmoandal wants to merge 1 commit into
salignatmoandal wants to merge 1 commit into
Conversation
Per-sample max over alternate golds already lives in DropMetrics; using max across documents made one correct sample report em/f1 of 1.0. Closes huggingface#1395.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metrics.dropcorpus aggregation frommaxtonp.meanfor bothemandf1.DropMetrics; only the across-document aggregation was wrong.0.25, not1.0.Closes #1395.
Context
DropMetrics.computealready takes the max over gold spans for a single document.MetricsLogger.aggregatethen appliedcorpus_level_fn={"em": max, "f1": max}, so any single exact hit made the reported task score1.0. That diverges from lm-eval-harness DROP (aggregation: mean) and fromMetrics.exact_matchin the same file.The built-in
lighteval|droptask usesMetrics.exact_match, so its numbers are unaffected. Custom tasks that selectMetrics.dropwere reporting inflated scores.Test plan
pytest tests/unit/metrics/test_drop_aggregation.py— 2 passedruff check/ruff format --checkon changed files