Repository navigation
fix(exact_match): strip unicode and multilingual punctuation when ignore_punctuation is True - #837
Open
reginaldalfret wants to merge 1 commit into
Conversation
…ore_punctuation is True Closes huggingface#836 Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #836
When
ignore_punctuation=Truewas passed to theexact_matchmetric, it previously constructed a translation table usingstring.punctuation:This only removed standard ASCII punctuation (
!"#$%&\'()*+,-./:;<=>?@[\\]^_{|}~). As a result, non-ASCII and multilingual punctuation marks (e.g. Arabic comma،, Spanish inverted marks¿¡, European quotes«», and CJK punctuation，。！？) were preserved, causing correct multilingual answers to score0.0`.Solution
unicodedata.category(c).startswith("P")) while retaining all characters instring.punctuationfor full backwards compatibility.ExactMatch._computereturns a native float so that numpy 2.0+ does not wrap the result innp.float64(...).tests/test_exact_match_unicode.pycovering ASCII, Arabic, CJK, inverted Spanish marks, and quote marks.Before submitting