Repository navigation
Speed up evaluate imports with lazy loading - #833
Open
MonikaDvorackova wants to merge 2 commits into
Open
MonikaDvorackova wants to merge 2 commits into
MonikaDvorackova wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #674.
import evaluate.evaluate.evaluator.Benchmark
Representative measurements on macOS:
import evaluatefrom evaluate import loadfrom evaluate import EvaluationSuitefrom evaluate import evaluatorImport timings varied substantially between runs. The main improvement is consistently observed for plain
import evaluate; other imports may still load heavy dependencies on first access.Validation
The complete test suite was not run because some optional dependencies were not installed.
Additional local benchmark (Python 3.10, macOS)
Seven subprocess measurements per import; median values.
import evaluatefrom evaluate import loadfrom evaluate import EvaluationSuitefrom evaluate import evaluatorPlain
import evaluatewas approximately 59x faster.The
evaluatorimport was slower in this measurement.Results may vary across runs and environments.
Additional validation:
The complete project test suite has not yet been verified in this environment.