fix: Replace bare except with except Exception - #14517
Open
Ricardo-M-L wants to merge 1 commit into
Open
Conversation
Bare `except:` clauses catch `SystemExit` and `KeyboardInterrupt`, preventing graceful shutdown and making the process uninterruptible. Replace with `except Exception:` which preserves the original error-handling behavior while allowing system-exiting exceptions to propagate. Affected locations: - utils/hub_utils.py:301 — fallback download path - experimental/rl/value_guided_sampling.py:60,66 — dataset stat computation Signed-off-by: Ricardo-M-L <Sibyl_Hartmanbnb@webname.com>
Contributor
|
Hi @Ricardo-M-L, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean rebase