Skip to content

fix: Fix double-shift in FlowMatchEulerDiscreteScheduler.__init__ #14508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ricardo-M-L wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix: Fix double-shift in FlowMatchEulerDiscreteScheduler.__init__ #14508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/diffusers/schedulers/scheduling_flow_match_euler_discrete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,13 @@ def __init__(
timesteps = torch.from_numpy(timesteps).to(dtype=torch.float32)

sigmas = timesteps / num_train_timesteps
# Store sigma_min / sigma_max from the *unshifted* sigmas. `set_timesteps` uses these
# to seed the per-call schedule and then re-applies `shift` itself — storing the
# post-shift values here would make `set_timesteps` shift a second time and produce
# sigmas that don't match `__init__`'s schedule (#13243).
self.sigma_min = sigmas[-1].item()
self.sigma_max = sigmas[0].item()

if not use_dynamic_shifting:
# when use_dynamic_shifting is True, we apply the timestep shifting on the fly based on the image resolution
sigmas = shift * sigmas / (1 + (shift - 1) * sigmas)
Expand All @@ -140,8 +147,6 @@ def __init__(
self._shift = shift

self.sigmas = sigmas.to("cpu") # to avoid too much CPU/GPU communication
self.sigma_min = self.sigmas[-1].item()
self.sigma_max = self.sigmas[0].item()

@property
def shift(self):
Expand Down
Loading