Skip to content

fix: Fix RecursionError in CosineDPMSolver Brownian tree noise sampler #14506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ricardo-M-L wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix RecursionError in CosineDPMSolver Brownian tree noise sampler #14506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/diffusers/schedulers/scheduling_cosine_dpmsolver_multistep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,10 +659,15 @@ def step(
seed = (
[g.initial_seed() for g in generator] if isinstance(generator, list) else generator.initial_seed()
)
# Use the actual sigma extrema rather than the config values: the Karras
# reconstruction of `sigma_max` in fp32 can drift a few ULPs above the
# config value, and `sigma_next == 0` (final_sigmas_type="zero") is
# strictly below `config.sigma_min`. Both out-of-range queries drive
# torchsde into unbounded interval splitting (#13274).
self.noise_sampler = BrownianTreeNoiseSampler(
model_output,
sigma_min=self.config.sigma_min,
sigma_max=self.config.sigma_max,
sigma_min=self.sigmas.min().item(),
sigma_max=self.sigmas.max().item(),
seed=seed,
)
noise = self.noise_sampler(self.sigmas[self.step_index], self.sigmas[self.step_index + 1]).to(
Expand Down
Loading