Conversation
SSLHelper generates its CA once per process but wrote it to the shared tmp/certs/ca.crt, and OpenSSL only reads ca_file when a context is set up for a handshake. When tests run in several processes at once, as mutant's workers do, the last process to write the file replaces every other process's CA, and their handshakes fail with "certificate verify failed (certificate signature failure)". Trust the CA through an in-memory certificate store instead. The server context no longer sets ca_file, since it does not verify clients.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSLHelpergenerates its CA once per process but writes it to the sharedtmp/certs/ca.crt, and OpenSSL readsca_fileonly when a context sets up a handshake. With several test processes running at once, as mutant's workers do, the last one to write the file replaces everyone else's CA, and their TLS tests fail with "certificate verify failed (certificate signature failure)".This trusts the CA through an in-memory
OpenSSL::X509::Storeinstead. The server context dropsca_filetoo, since it doesn't verify clients, andtmp/certsisn't written anymore..mutant.ymlignores the TLS-touching subjects today, so CI doesn't hit this. I did when mutatingHTTP::Clientcode for another branch:-j 16without this: neutral failures, "certificate signature failure"-j 1