-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add managed database helpers to HotdataClient #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cbccf1e
feat: add managed database helpers to HotdataClient
eddietejeda af29d9c
chore: pin hotdata>=0.1.1 and bump to 0.1.1
eddietejeda a370abb
chore: require hotdata>=0.2.0
eddietejeda 2d3d410
fix: address PR review nits for managed database helpers
eddietejeda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| """Managed database helpers (Hotdata-owned catalogs with parquet table loads).""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from dataclasses import asdict, dataclass | ||
| from pathlib import Path | ||
| from typing import Any | ||
|
|
||
| from hotdata.exceptions import ApiException | ||
| from hotdata.models.create_connection_request import CreateConnectionRequest | ||
|
|
||
| MANAGED_SOURCE_TYPE = "managed" | ||
| DEFAULT_SCHEMA = "public" | ||
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class ManagedDatabase: | ||
| id: str | ||
| name: str | ||
| source_type: str | ||
|
|
||
| def to_dict(self) -> dict[str, Any]: | ||
| return asdict(self) | ||
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class ManagedTable: | ||
| full_name: str | ||
| schema: str | ||
| table: str | ||
| synced: bool | ||
| last_sync: str | None | ||
|
|
||
| def to_dict(self) -> dict[str, Any]: | ||
| return asdict(self) | ||
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class LoadManagedTableResult: | ||
| connection_id: str | ||
| schema_name: str | ||
| table_name: str | ||
| row_count: int | ||
| full_name: str | ||
|
|
||
| def to_dict(self) -> dict[str, Any]: | ||
| return asdict(self) | ||
|
|
||
|
|
||
| def is_parquet_path(path: str) -> bool: | ||
| return Path(path).suffix.lower() == ".parquet" | ||
|
|
||
|
|
||
| def build_managed_config(schema: str, tables: list[str]) -> dict[str, Any]: | ||
| if not tables: | ||
| return {} | ||
| return { | ||
| "schemas": [ | ||
| { | ||
| "name": schema, | ||
| "tables": [{"name": table} for table in tables], | ||
| } | ||
| ] | ||
| } | ||
|
|
||
|
|
||
| def create_connection_request( | ||
| name: str, | ||
| *, | ||
| schema: str = DEFAULT_SCHEMA, | ||
| tables: list[str] | None = None, | ||
| ) -> CreateConnectionRequest: | ||
| table_list = tables or [] | ||
| return CreateConnectionRequest( | ||
| name=name, | ||
| source_type=MANAGED_SOURCE_TYPE, | ||
| config=build_managed_config(schema, table_list), | ||
| skip_discovery=True, | ||
| ) | ||
|
|
||
|
|
||
| def managed_database_from_connection(conn: Any) -> ManagedDatabase: | ||
| return ManagedDatabase( | ||
| id=str(conn.id), | ||
| name=str(conn.name), | ||
| source_type=str(conn.source_type), | ||
| ) | ||
|
|
||
|
|
||
| def api_error_message(exc: ApiException) -> str: | ||
| return exc.reason or str(exc) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.