feat(update): background update check with post-command notice#104
Merged
Conversation
Spawn the GitHub release check in a background thread before the command runs, then join it (recv_timeout 6 s) after the command finishes so the notice always appears at the bottom of output. Uses mpsc::Receiver instead of JoinHandle::join to prevent blocking if the HTTP request stalls past its own 5 s timeout. Unifies the notice message to "hotdata update" for all install methods. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recv_timeout(6s), ensuring the notice always appears at the bottom of outputmpsc::Receiverinstead ofJoinHandle::jointo avoid indefinite blocking if the HTTP request stalls past its own 5s timeouthotdata updatefor all install methods (drops the Homebrew-specific branch in the notice)Test plan
hotdata query status <id>) when a newer version exists — notice appears after command output in yellowhotdata update— no notice printed (skipped for the update command itself)HOTDATA_NO_UPDATE_CHECK=1— no notice printed🤖 Generated with Claude Code