Feat/initial eas16.1 support#166
Merged
Merged
Conversation
* parse proposed start/end and send RFC5546 COUNTER updates * respect DisallowNewTimeProposal/disallow-counter flags * keep standard attendee response flow with separate counter handling
Include VERSION_SIXTEENONE in the supported-version list used when resolving horde:activesync:version permissions. Without it, a per-user ceiling of 16.1 was ignored and the global 16.0 default remained in effect. Add regression test for 16.1 per-user permission resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(core): add EAS 16.1 meeting proposal handling in MeetingResponse
Summary
Extends
Horde_Core_ActiveSync_Driver::meetingResponse()to handle EAS 16.1ProposedStartTime/ProposedEndTime: send RFC5546METHOD=COUNTERto the organizer (viahorde/itip), respect disallow-counter iCal flags, and keep the existingMETHOD=REPLYpath whenSendResponseis set.Motivation
horde/activesyncparses 16.1 proposal fields fromMeetingResponseWBXML; this PR is the application-layer bridge that turns them into standards-compliant iTip COUNTER messages and enforces organizer policy.Changes
meetingResponse()(EAS ≥16.1)proposedstarttime/proposedendtimefrom the request array (UTCHorde_Date).ProposedEndTimewithout start; derive end from original meeting duration when end omitted.DISALLOW-COUNTER,X-MICROSOFT-DISALLOW-COUNTER, orX-MS-DISALLOW-COUNTERset to a true-like value, clear proposal (no COUNTER sent).sendresponseand/or proposal present:sendMultiPartResponse()whensendresponseis set.sendCounterMultiPartResponse()when proposed start is present.Docblock
proposedstarttime/proposedendtimerequest keys.Files changed
(No new tests in core for this slice; behaviour is covered by
horde/itipintegration tests and manual EAS testing. Optional follow-up: unit test with mockedHorde_Itip.)Dependencies
VERSION_SIXTEENONE,MeetingResponseparsing passes proposed times into driver.Horde_Itip::sendCounterMultiPartResponse().Merge after activesync and itip, before or in parallel with imp (IMP does not call core meetingResponse directly).
Test plan
php -l lib/Horde/Core/ActiveSync/Driver.phpvendor/bin/phpunit test/Unit/ActiveSync/suite passes (no regression in version callback / draft sync).SendResponse+ proposal → both REPLY and COUNTER when applicable.Suggested commit message
Implementation reference
Key logic added after instance-id handling and before calendar import:
$vEvent.sendMultiPartResponse(reply) +sendCounterMultiPartResponse(counter).