Repository navigation
chore: security A and coverage above 90% on SonarCloud - #35
Merged
Merged
Conversation
Security: the one open vulnerability was publish_nuget.yml expanding
${{ secrets.NUGET_TOKEN }} inside the run block - the same finding fixed in
sonarcloud.yml by #34. The token now reaches the script through env.
Coverage: the library was at 99%; the 89.9% overall came from the API
project, where OrderRepository and Order had no test at all and
ProductRepository.SyncDataThenCommit's catch never ran. OrderRepositoryTest
sends the FK / DateOnly entity the benchmarks use through every repository
method against MySQL; EfCoreTest gains the commit-path failure.
Maintainability (the 10 new issues from #34): the ON / SET / ON DUPLICATE
KEY UPDATE loops in BulkCommand become two helpers built on string.Join,
column selection moves out of the update and merge generators so each drops
below the complexity limit, the TODO and commented-out FieldsToUpdate block
leave BulkOption (the design now lives in docs/roadmap.md, not yet
committed), EdgeCaseTest uses static readonly arrays, and two members
nothing read - ColumnInfo.IsKey, BatchData.SuccessCount - are removed along
with a redundant OpenAsync in ExecuteBatchDataAsync. Generated SQL is
unchanged: every exact-string assertion in BulkCommandTest still passes.
Tests: 61 -> 68.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E63oHuiKenf9H6tcgvDXVG
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security: the one open vulnerability was publish_nuget.yml expanding ${{ secrets.NUGET_TOKEN }} inside the run block - the same finding fixed in sonarcloud.yml by #34. The token now reaches the script through env.
Coverage: the library was at 99%; the 89.9% overall came from the API project, where OrderRepository and Order had no test at all and ProductRepository.SyncDataThenCommit's catch never ran. OrderRepositoryTest sends the FK / DateOnly entity the benchmarks use through every repository method against MySQL; EfCoreTest gains the commit-path failure.
Maintainability (the 10 new issues from #34): the ON / SET / ON DUPLICATE KEY UPDATE loops in BulkCommand become two helpers built on string.Join, column selection moves out of the update and merge generators so each drops below the complexity limit, the TODO and commented-out FieldsToUpdate block leave BulkOption (the design now lives in docs/roadmap.md, not yet committed), EdgeCaseTest uses static readonly arrays, and two members nothing read - ColumnInfo.IsKey, BatchData.SuccessCount - are removed along with a redundant OpenAsync in ExecuteBatchDataAsync. Generated SQL is unchanged: every exact-string assertion in BulkCommandTest still passes.
Tests: 61 -> 68.
Claude-Session: https://claude.ai/code/session_01E63oHuiKenf9H6tcgvDXVG