test: add behavior tests for RelatedProjects sidebar component - #140
Merged
Merged
Conversation
Covers pathname-based project highlighting, branch-deploy URL prefixing, the static config fallback, the Legacy section collapse/expand and autoExpandLegacy sync, recursive legacy menu-tree rendering, and the slim variant's theme toggle and onCollapse button. Lifts the file from 0% to ~90% line coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
src/__tests__/RelatedProjects.behavior.test.tsx(13 tests) forsrc/components/docs/RelatedProjects.tsx, previously the largest fully-uncovered file insrc/(399 lines, 0%). Follows the existing behavior-test pattern (jsdom pragma;vi.mockofnext/navigation,next-themes,next/link,@/hooks/useSharedConfig).Covered behavior:
getCurrentProject()pathname→highlight mapping, general-section highlighting, and the Hive fallbackgetProjectUrl()branch-deploy handling: relative on production-like hosts, absolutehttps://docs.hivecommons.devprefix (rendered as plain<a>) elsewhereautoExpandLegacyprop sync across rerendersrenderLegacyMenuTree(): depth<2 always visible, depth≥2 expand/collapse buttons,Linkvs<a>selection,#route fallback, tree hidden for non-current projectssetThemewith the opposite theme; expand button callsonCollapseResults: file 0% → 89.7% lines; suite 726 → 739 tests, all green; overall lines 73.9% → 78.1%.
eslintandtsc --noEmitclean. Includes achangelog.d/added-fragment.Closes #139
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5 copilot=1.0.88