docs(buildfile): note load() is confined to the workspace root - #83
Open
raphaelvigee wants to merge 1 commit into
Open
docs(buildfile): note load() is confined to the workspace root#83raphaelvigee wants to merge 1 commit into
raphaelvigee wants to merge 1 commit into
Conversation
load() now enforces the same workspace-root boundary as file()/glob()/query() — a `..`-laden path that would resolve outside the workspace is rejected instead of being followed. Ref: hephbuild/heph@66dea21 (#277)
⚡ Cloudflare Pages preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hephbuild/heph#277(commit66dea21) closed a security bug whereload()path resolution had no workspace-root boundary check, so a..-laden or//-absolute path (e.g.load("../../../../etc/hosts")) could escape the workspace and be parsed as Starlark.load()now enforces the same boundary check asfile()/glob()/query(), rejecting such paths with an error.website/docs/plugins/buildfile.mdalready documented this workspace-root boundary forfile()/glob()/query()paths, but was silent onload(). Added one sentence to the "Sharing symbols withload()" section mirroring the existing statement, now thatload()behaves the same way.Not documented (out of scope, no user-facing docs claim to correct): the companion fix for package-address escapes (
Provider::get/list/probenow returning empty/not-found for a..-escaping package address) and thelist_packagessymlinked-BUILD-file fix — both are internal consistency fixes with no prior doc claims to update.Test plan
Generated by Claude Code