Los instaladores, a v0.1.5 - #61
Merged
Merged
Conversation
v0.1.4's PowerShell installer closed the terminal it ran in. `iex` executes in the current session, so the `exit 1` on every failure path ended the session rather than the script: the tab shut instantly and took the error message with it, which made every failure look like the same silent one. Reported from Warp, reproduced, fixed in helmcode/nan-cli#6. /install moves with it. Its script is unchanged since v0.1.4, but the two pins are tested to name the same tag and there is nothing to gain from them drifting. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.1.4's PowerShell installer closed the terminal it ran in.
iexexecutes in the current session, so theexit 1on every failure path ended the session rather than the script: the tab shut instantly and took the error message with it, which made every kind of failure look like the same silent one.Reported from Warp, reproduced, fixed in helmcode/nan-cli#6 and released as v0.1.5.
/installmoves with it. Its script is unchanged since v0.1.4, but the two pins are tested to name the same tag and there is nothing to gain from them drifting.