forked from tiann/hapi
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(tooling): soup hotfiles check in driver-rebuild --verify #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
heavygee
wants to merge
1
commit into
main
Choose a base branch
from
fix/soup-hotfiles-verify-gate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| #!/usr/bin/env bun | ||
| /** | ||
| * Soup hot-file consistency gate — run from hapi-driver-rebuild --verify. | ||
| * | ||
| * Catches layer-collision class bugs where syncEngine keeps rpcGateway calls | ||
| * but a later manifest layer dropped the matching rpcGateway method (or REST route). | ||
| * | ||
| * Usage: bun run hapi-soup-hotfiles-check.mjs [driver-dir] | ||
| */ | ||
| import { readFileSync } from 'node:fs' | ||
| import { join } from 'node:path' | ||
|
|
||
| const driver = process.argv[2] ?? process.env.HAPI_DRIVER ?? join(process.env.HOME, 'coding/hapi/driver') | ||
|
|
||
| function read(rel) { | ||
| return readFileSync(join(driver, rel), 'utf8') | ||
| } | ||
|
|
||
| const syncEngine = read('hub/src/sync/syncEngine.ts') | ||
| const rpcGateway = read('hub/src/sync/rpcGateway.ts') | ||
|
|
||
| const calls = [...new Set([...syncEngine.matchAll(/this\.rpcGateway\.(\w+)\(/g)].map((m) => m[1]))] | ||
| const methods = new Set([...rpcGateway.matchAll(/^\s+async (\w+)\(/gm)].map((m) => m[1])) | ||
|
|
||
| const missing = calls.filter((name) => !methods.has(name)) | ||
| if (missing.length > 0) { | ||
| console.error('hapi-soup-hotfiles-check: FAIL') | ||
| console.error(' syncEngine -> rpcGateway calls missing from rpcGateway:', missing.join(', ')) | ||
| console.error(' Add a collision-repair manifest layer — docs/tooling/driver-soup.md § Layer collisions.') | ||
| process.exit(1) | ||
| } | ||
|
|
||
| if (syncEngine.includes('listCodexSessionsForMachine')) { | ||
| const machines = read('hub/src/web/routes/machines.ts') | ||
| if (!machines.includes('/codex-sessions')) { | ||
| console.error('hapi-soup-hotfiles-check: FAIL') | ||
| console.error(' syncEngine.listCodexSessionsForMachine but machines.ts missing GET /codex-sessions') | ||
| process.exit(1) | ||
| } | ||
| } | ||
|
|
||
| console.log(`hapi-soup-hotfiles-check: OK (${calls.length} rpcGateway call site(s) checked)`) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
syncEnginecalls a generic gateway method with type arguments, as it already does withthis.rpcGateway.callPiRpc<T>(...), this scan requires the method name to be followed immediately by(and the method definition pattern has the same limitation forasync callPiRpc<T = unknown>(...). In that collision case the new hot-file gate can still print OK while a generic rpcGateway call/method pair is missing from the advertisedsyncEngine⊆rpcGatewayparity check.Useful? React with 👍 / 👎.