refactor: Cleanup config - #179
Merged
Merged
Conversation
- SysRuntime → AppCtx: non-singleton, built once in main and borrowed through dispatch (no leak, no global); async init loads user config and opens the creds store concurrently. - Add ProjectCtx<'app>: workspace root + resolved config, resolved against the AppCtx's user config; eager .hm/ paths. - Extract credentials out of config into its own module. Single active token via CredsProvider (get/set/clear) using secrecy::SecretString; HM_API_TOKEN still wins. Replaces the (service, account)-keyed credentials.toml with ~/.hm/creds/token. - DirProvider::home(); rename modules app_ctx/project_ctx.
markovejnovic
marked this pull request as ready for review
July 26, 2026 23:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.