Skip to content

Update the GHA helper-script create-new-issue.js #8794

Description

@yielderdev

Overview

We need to update the GHA helper-script create-new-issue.js to eliminate future technical debt.

Prerequisites

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.

  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We need to update the GHA helper-script create-new-issue.js1 to import the current Agenda Issue number from static-issue-nums.json to eliminate future technical debt.

Details

  1. We should update the GHA helper-script create-new-issue.js to import the current Agenda Issue number from static-issue-nums.jsonrather than using a local hard-coded constant, so that only static-issue-nums.json needs to be updated when the Agenda Issue number changes.

  2. If we do not, each year when the Agenda Issue number is updated, the Agenda Issue number will need to be updated in multiple locations.

Action Items

  • Require the static-issue-nums.json in create-new-issue.js1 with the following :
const STATIC_ISSUE_NUMS = require("../../utils/_data/static-issue-nums.json");
  • Update the postComment() call currently using AGENDA_ISSUE_NUM to instead use STATIC_ISSUE_NUMS.AGENDA
  • When you open your pull request, at the bottom your main body add this text:
### For Merge Team
- When this issue is ready to merge, test the github action before using.

Resources

Footnotes

  1. create-new-issue.js ↩ ↩2

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions