You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Hi there!
I created a simple implementation for RSocket #327.
GraphQL query is supported by RSocket REQUEST-RESPONSE. Available on graphql endpoint.
GraphQL subscription is supported by RSocket REQUEST-STREAM. Available on subscription endpoint.
Set up RSocket over WebSocket protocol by default on 7000 port.
But there is a question about subscription:
What about operations?
Do we really need to support it over RSocket? The start, end, error... frames are handled by RSocket native
Also here is code duplicate MonoAutoConfiguration.java. I'll refactor it after discussion about this feature :)
Thanks a lot for the effort and your contribution! Please note that we're on the verge of merging a major module restructure, see #617. This means your PR will have to be updated in line with that one. You could already rebase your branch on that starter-reorganization branch or just wait until we've merged that one to master.
The GQL_ messages you've described are part of the Apollo Client subscription protocol. I'm not familiar (yet) with RSocket, but to be able to support Apollo Client subscriptions, that protocol should be supported. Maybe it could be extracted somehow to be used in both implementations, but haven't been able to look at it yet to judge.
@oliemansm Thank you for answer! I see #617 was merged. So I continue my work on rsocket implementation and try to find a way of Apollo Client subscription protocol problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I created a simple implementation for RSocket #327.
GraphQL query is supported by RSocket REQUEST-RESPONSE. Available on
graphqlendpoint.GraphQL subscription is supported by RSocket REQUEST-STREAM. Available on
subscriptionendpoint.Set up RSocket over WebSocket protocol by default on 7000 port.
But there is a question about subscription:
What about operations?
Do we really need to support it over RSocket? The start, end, error... frames are handled by RSocket native
Also here is code duplicate
MonoAutoConfiguration.java. I'll refactor it after discussion about this feature :)