test: build registry test mocks on the shared stub - #722
Merged
MoonBoi9001 merged 2 commits intoOct 2, 2026
Merged
MoonBoi9001 merged 2 commits into
MoonBoi9001 merged 2 commits into
Conversation
The doc comment on the shared test settings spelled the configured value 0 as a word, against the house rule that quantities and configured values are written as numerals.
Three test mocks implemented every registry method by hand, most as placeholders, so each new registry method meant editing all of them. They now build on the shared stub and keep only the methods their tests rely on.
MoonBoi9001
added this pull request to stack #723
October 2, 2026 22:01
MoonBoi9001
removed this pull request from stack #723
October 2, 2026 22:01
MoonBoi9001
marked this pull request as ready for review
October 2, 2026 22:02
MoonBoi9001
added this pull request to stack #724
October 2, 2026 22:04
MoonBoi9001
removed this pull request from stack #724
October 2, 2026 22:10
MoonBoi9001
added this pull request to stack #725
October 2, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three registry test mocks now build on the shared stub instead of implementing every method by hand, so a new registry method no longer means editing each of them, and a doc comment writes its configured value as a numeral.