ci: pin release-please-action to its commit SHA - #115
Merged
Conversation
#114 pinned release-please-action to 0dfd8538, which is the SHA of the annotated `v5` tag *object*, not the commit it points to. The runner dereferences it fine (the release job ran green), but it isn't a commit SHA, so it breaks the SHA-pin convention and Renovate keeps re-proposing the correction each cycle. Repin to 45996ed — the actual v5.0.0 release commit (both `v5` and `v5.0.0` dereference to it) — matching how every other action here is pinned and clearing the recurring Renovate dashboard entry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
cbetta
marked this pull request as ready for review
July 28, 2026 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #114. Renovate's dashboard kept proposing
chore(deps): update googleapis/release-please-action digest to 45996ed, which surfaced a subtlety in the pin #114 introduced.googleapis/release-please-actionuses an annotatedv5tag. In #114 I resolved it viagit/ref/tags/v5, which returns the SHA of the tag object (0dfd8538), not the commit it points to. This repins to the actual v5.0.0 release commit45996ed— bothv5andv5.0.0dereference to it.This was not breaking
To be clear: the merged #114 pin works at runtime. The runner dereferences the tag object automatically, and the release-please job ran green on the #114 merge commit (run). So no production impact.
The reason to fix it anyway:
Verification
45996edconfirmed as a real commit (chore(main): release 5.0.0), not a tag object.release.ymlYAML validated.🤖 Generated with Claude Code