fix(documentai-toolbox): enable autoescape in export_hocr_str - #18140
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables autoescaping (autoescape=True) in the Jinja2 environment within export_hocr_str to prevent potential injection vulnerabilities, and adds a corresponding unit test test_export_hocr_str_escapes_title to verify that HTML/XML tags in the title are properly escaped. There are no review comments, so I have no feedback to provide.
parthea
approved these changes
Aug 18, 2026
parthea
enabled auto-merge (squash)
August 18, 2026 14:52
Contributor
|
Thanks @Samin061! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
export_hocr_str builds its Jinja2 Environment without autoescape, so the title argument is written into the
<title>element unescaped. A title such as</title><script>alert(1)</script>breaks out of the element and lands as raw script markup, producing invalid XML in an hOCR document that is meant to be valid XHTML rendered in a browser. The word and line text already pass through theescapefilter, so enabling autoescape closes the remaining gap inside the helper while leaving the output byte-identical for normal input (existing golden-file tests are unchanged).