Skip to content

chore: revert patch BC check for internal final property fix #9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshaffer merged 3 commits into from
Sep 17, 2026
Merged

chore: revert patch BC check for internal final property fix #9703

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a898b0
Revert "fix(ci): patch BC check for internal final property fix (#9697)"
bshaffer Sep 17, 2026
cb936d1
Apply suggestion from @bshaffer
bshaffer Sep 17, 2026
be9c5be
Update PHP version from 8.2 to 8.4 in workflow
bshaffer Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/release-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: "Install PHP"
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # v2
with:
php-version: "8.2"
php-version: "8.4"
- name: "Rebase PR branch onto main branch"
if: github.event.pull_request.user.login != 'release-please[bot]'
env:
Expand All @@ -33,10 +33,7 @@ jobs:
exit 1
fi
- name: "Install dependencies"
run: |
composer global require "roave/backward-compatibility-check:^8.2"
# TODO: Remove this line after https://github.com/googleapis/google-cloud-php/pull/9697 is merged and released
sed -i.bak 's/return ($this->propertyBased)/return (new ExcludeInternalProperty($this->propertyBased))/' ~/.composer/vendor/roave/backward-compatibility-check/src/DetectChanges/BCBreak/PropertyBased/OnlyPublicPropertyChanged.php
run: composer global require "roave/backward-compatibility-check:^8.22"
- name: "Check for BC breaks"
if: github.event.pull_request.user.login != 'release-please[bot]'
run: |
Expand Down
Loading