refactor(storage): remove Service.ts and migrate logic to StorageTransport

[thiyaguk09]

Removed:

• handwritten/storage/system-test/common.ts
• handwritten/storage/test/nodejs-common/service.ts
• handwritten/storage/src/nodejs-common/service.ts

Updated:

• Bumped conformance test Node version from 14 to 18

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

[gemini-code-assist]

Code Review

This pull request deletes the Service class along with its unit and system tests, likely as part of a migration to a new StorageTransport implementation. However, the PR is currently incomplete as the replacement implementation is not included, which will lead to build failures. The feedback emphasizes that several critical functionalities must be preserved or improved in the new transport: project ID detection logic, support for modern Cloud Functions environment variables (K_SERVICE), correct timeout precedence, robust URL detection, and GCS-specific colon separator handling. Furthermore, the deleted system tests should be migrated to maintain test coverage for request handling and retries.

[Dhriti07]

Code Review

This pull request deletes the Service class along with its unit and system tests, likely as part of a migration to a new StorageTransport implementation. However, the PR is currently incomplete as the replacement implementation is not included, which will lead to build failures. The feedback emphasizes that several critical functionalities must be preserved or improved in the new transport: project ID detection logic, support for modern Cloud Functions environment variables (K_SERVICE), correct timeout precedence, robust URL detection, and GCS-specific colon separator handling. Furthermore, the deleted system tests should be migrated to maintain test coverage for request handling and retries.

@thiyaguk09 Can you check this ?

[thiyaguk09]

Code Review

This pull request deletes the Service class along with its unit and system tests, likely as part of a migration to a new StorageTransport implementation. However, the PR is currently incomplete as the replacement implementation is not included, which will lead to build failures. The feedback emphasizes that several critical functionalities must be preserved or improved in the new transport: project ID detection logic, support for modern Cloud Functions environment variables (K_SERVICE), correct timeout precedence, robust URL detection, and GCS-specific colon separator handling. Furthermore, the deleted system tests should be migrated to maintain test coverage for request handling and retries.

@thiyaguk09 Can you check this ?

@Dhriti07 The StorageTransport was already implemented and integrated prior to this PR. All unit tests are passing, and since the migration is complete, removing these files will not cause build failures.

All critical logic—including project ID detection, K_SERVICE support, and GCS-specific handling—has been preserved in the new transport layer. This is simply the final cleanup to remove redundant code.