chore: clean up per-package eslintrc configurations#8266
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces multiple .eslintrc.json files with a new packages/eslint.config.mjs flat configuration. The review feedback highlights several critical issues: the new configuration lacks the previously used gts rules, includes redundant default ignores for node_modules, and excludes system-test directories from linting. Furthermore, the reviewer noted that this configuration must be explicitly imported into a root-level file to be active.
shivanee-p
force-pushed
the
shivaneep-eslint-cleanup-gapic
branch
from
47e0339 to
1b9ba65
Compare
|
/gemini review |
shivanee-p
changed the title
There was a problem hiding this comment.
Code Review
This pull request removes several .eslintrc.json configuration files and templates across various packages and the generator. The review feedback highlights a critical concern: deleting these templates without updating the generator's source code will likely result in "file not found" errors during execution. Additionally, the reviewer pointed out that the cleanup is incomplete, as .eslintignore files and templates remain despite the PR description stating they would be removed.
I am having trouble creating individual review comments. Click here to see my feedback.
core/generator/gapic-generator-typescript/templates/cjs/typescript_gapic/.eslintrc.json.njk (1-4)
Deleting these template files without updating the generator's source code (the logic that explicitly renders these templates) will likely cause the generator to fail with "file not found" errors. The PR description mentions removing the "generation logic", but no changes to the generator's source code (e.g., .ts files) are included in this diff to remove the references to these templates.
core/generator/gapic-generator-typescript/templates/cjs/typescript_gapic/.eslintrc.json.njk (1-4)
The pull request description states that the generation logic for both .eslintignore and .eslintrc.json files is being removed. However, the .eslintignore.njk templates (in both cjs and esm directories) are not deleted in this diff. These should be removed to align with the PR's objective and ensure that no legacy configuration files are generated in the future.
packages/google-analytics-data/.eslintrc.json (1-4)
The PR description mentions removing both .eslintignore and .eslintrc.json files. While the .eslintrc.json files are being deleted from these packages, the corresponding .eslintignore files are not included in the diff. If these files exist in the package directories, they should also be removed to complete the cleanup of legacy per-package configurations.
shivanee-p
force-pushed
the
shivaneep-eslint-cleanup-gapic
branch
3 times, most recently
from
03e51c1 to
e79b47c
Compare
…e generator template configs
shivanee-p
force-pushed
the
shivaneep-eslint-cleanup-gapic
branch
from
e79b47c to
d0a15cf
Compare
1 participant
Remove the per-package generation logic for the .eslintignore and .eslintrc.json files within the GAPIC libraries
This PR cleans up legacy per-package linter configurations across the generated GAPIC libraries to prepare for linter implementation under ESLint v10. The individual per-package configurations are being consolidated into a unified, top-level flat configuration architecture to reduce merge conflicts and maintenance overhead.
Fixes #4585 🦕