chore: relocate two packages from packages to core, as they are handwritten#8263
Open
feywind wants to merge 2 commits into
Open
chore: relocate two packages from packages to core, as they are handwritten#8263feywind wants to merge 2 commits into
feywind wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces significant updates to the gapic-node-processing package, focusing on library bootstrapping, combining multiple libraries, and template-based generation of READMEs and other project files. The changes include new CLI commands, updated templating logic, and an extensive set of test fixtures for Google Analytics and Google Cloud Speech libraries to ensure correct processing of combined GAPIC clients. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says.
googleapis/librarian#4803