feat(gax): implement startUploadCallable for resumable uploads - #14139
Draft
whowes wants to merge 1 commit into
Draft
feat(gax): implement startUploadCallable for resumable uploads#14139whowes wants to merge 1 commit into
whowes wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
changed the title
whowes
force-pushed
the
whowes/resumable-upload-start
branch
2 times, most recently
from
August 20, 2026 00:06
8d52acf to
7df9201
Compare
Contributor
Author
|
/gemini review |
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 20, 2026 00:10
7df9201 to
4253855
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces HttpJsonResumableUploadClient to support resumable uploads over HTTP/JSON, along with a comprehensive suite of unit tests. The feedback suggests validating that the parsed chunk granularity is strictly positive to prevent potential arithmetic errors or infinite loops.
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 20, 2026 01:38
4253855 to
798876d
Compare
whowes
changed the title
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 21, 2026 00:37
798876d to
a071113
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 24, 2026 19:40
a071113 to
e43a3fa
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
2 times, most recently
from
August 25, 2026 16:34
3039c34 to
56d1462
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 25, 2026 21:44
56d1462 to
22569f9
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
2 times, most recently
from
August 26, 2026 17:56
7072e2b to
0b792ed
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 26, 2026 18:12
0b792ed to
5b6cbd7
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 26, 2026 18:28
5b6cbd7 to
a139b72
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 26, 2026 18:38
a139b72 to
e8a7e9c
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
2 times, most recently
from
August 26, 2026 20:53
31ff4db to
7ef4002
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 27, 2026 00:42
7ef4002 to
adf4315
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 27, 2026 00:42
adf4315 to
3063624
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
2 times, most recently
from
August 27, 2026 01:49
25639e3 to
54650ed
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 27, 2026 01:50
54650ed to
6583572
Compare
whowes
force-pushed
the
whowes/resumable-upload-start
branch
from
August 27, 2026 15:27
6583572 to
e1cfc1c
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation uses a custom
HttpJsonClientCall.Listenerto extractX-Goog-Upload-URLandX-Goog-Upload-Chunk-Granularityheaders to be returned in aResumableUploadSession.