Skip to content

feat(gax): add getFirstHeader to HttpHeadersUtils - #14115

Draft
whowes wants to merge 1 commit into
whowes/start-unary-callfrom
whowes/get-first-header
Draft

feat(gax): add getFirstHeader to HttpHeadersUtils#14115
whowes wants to merge 1 commit into
whowes/start-unary-callfrom
whowes/get-first-header

Conversation

@whowes

@whowes whowes commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Stack created with GitHub Stacks CLIGive Feedback 💬

@whowes whowes changed the title whowes/get first header feat(gax): add getFirstHeader to HttpHeadersUtils Aug 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new utility method getFirstHeader in HttpHeadersUtils to retrieve the first string value of a header by case-insensitive name, supporting both single values and iterables. It also adds comprehensive unit tests in HttpHeadersUtilsTest to verify this new functionality. There are no review comments, and I have no additional feedback to provide.

@whowes
whowes force-pushed the whowes/get-first-header branch from 0dbf15c to 3a364dd Compare August 18, 2026 22:52
@whowes
whowes force-pushed the whowes/get-first-header branch from 3a364dd to 4295797 Compare August 18, 2026 23:39
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant