feat(bigtable): enable microsecond timestamps in client - #14057
Open
kanchi12P wants to merge 5 commits into
Open
feat(bigtable): enable microsecond timestamps in client#14057kanchi12P wants to merge 5 commits into
kanchi12P wants to merge 5 commits into
Conversation
kanchi12P
commented
Aug 12, 2026
kanchi12P
commented
- Enable microsecond timestamp flag in stub settings
- Plumb timestamp origin to Mutation setCell
- Skip emulator in mutation-based integration tests to prevent failures
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces microsecond timestamp granularity for Bigtable mutations, including setting the timestamp origin (client auto-generated vs. user-specified) and enabling the microsecond timestamp feature flag in stub settings. Integration tests are updated to skip emulator environments that do not support this granularity, and several protobuf-generated files are regenerated. The review feedback suggests avoiding a potential JDK overflow bug in the year 2262 by directly calculating microseconds since epoch instead of using Instant.until, and recommends adding a @Nonnull annotation to the timestampOrigin parameter for consistency.
kanchi12P
force-pushed
the
feature-microsecond-timestamps
branch
from
August 12, 2026 20:17
fe7343e to
41eff3e
Compare
Author
|
@mutianf Please review |
kanchi12P
force-pushed
the
feature-microsecond-timestamps
branch
from
August 13, 2026 05:55
41eff3e to
49bfa7c
Compare
mutianf
approved these changes
Aug 13, 2026
kanchi12P
force-pushed
the
feature-microsecond-timestamps
branch
4 times, most recently
from
August 14, 2026 06:49
e609c3b to
94f96f0
Compare
mutianf
changed the title
nimf
approved these changes
Aug 17, 2026
| public Mutation setCell( | ||
| @Nonnull String familyName, @Nonnull ByteString qualifier, @Nonnull ByteString value) { | ||
| long timestamp = System.currentTimeMillis() * 1_000; | ||
| Instant maxInstant = Instant.now(); |
Contributor
There was a problem hiding this comment.
sorry, why is it called maxInstant and not just instant?
- Enable microsecond timestamp flag in stub settings - Plumb timestamp origin to Mutation setCell - Skip emulator in mutation-based integration tests to prevent failures Change-Id: Ifd8824a5934f17c9d6a5e0e8cf8b0a0a7343ccb1
Change-Id: I42a732ca9a82884ccf97afcb734e317b4384455a
kanchi12P
force-pushed
the
feature-microsecond-timestamps
branch
2 times, most recently
from
August 17, 2026 18:24
3f50b5d to
7b5fb89
Compare
Change-Id: Iade245d7881798735bfb10598d9d1b4b4db0f4a1
kanchi12P
force-pushed
the
feature-microsecond-timestamps
branch
from
August 17, 2026 18:56
7b5fb89 to
57aa60c
Compare
…estamps Change-Id: I934a296af5a401ba02da7b377b3a2ad913a4fc01
yoshi-kokoro
removed
the
kokoro:run
…bePointWriteCallableTest Change-Id: I0a719ae140ab3f455e54e0233b26949738d20743
yoshi-kokoro
removed
the
kokoro:run
mutianf
enabled auto-merge (squash)
August 18, 2026 15:02
mutianf
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.