Repository navigation
Conversation
…ackcamera Moves `CameraModule` out of `com.google.jetpackcamera.di` into the root `com.google.jetpackcamera` package alongside `AppSettingsModule`. `com.google.jetpackcamera.di` contains shared dependency injection qualifiers (`@DefaultDispatcher`, `@IODispatcher`, `@DefaultCoroutineScope`, `@DefaultFilePathGenerator`) and generic app utilities (`AppModule`, `MediaModule`), whereas `CameraModule` binds the default app-level `CameraXCameraSystem`, `CameraSystemRepository`, and `ConstraintsRepository` implementations. Placing `CameraModule` in `com.google.jetpackcamera` keeps app-level camera system bindings separate from shared `di` qualifiers so host configurations that provide custom `CameraSystem` or `ConstraintsRepository` implementations can reuse the `di` package without duplicate Hilt bindings.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors CameraModule.kt by changing its package declaration from com.google.jetpackcamera.di to com.google.jetpackcamera and adding imports for dependency injection components including DefaultCoroutineScope, DefaultDispatcher, DefaultFilePathGenerator, and IODispatcher. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
CameraModuleout ofcom.google.jetpackcamera.diinto the rootcom.google.jetpackcamerapackage alongsideAppSettingsModule.com.google.jetpackcamera.dicontains shared dependency injection qualifiers (@DefaultDispatcher,@IODispatcher,@DefaultCoroutineScope,@DefaultFilePathGenerator) and generic app utilities (AppModule,MediaModule), whereasCameraModulebinds the default app-levelCameraXCameraSystem,CameraSystemRepository, andConstraintsRepositoryimplementations. PlacingCameraModuleincom.google.jetpackcamerakeeps app-level camera system bindings separate from shareddiqualifiers so host configurations that provide customCameraSystemorConstraintsRepositoryimplementations can reuse thedipackage without duplicate Hilt bindings.