Move GIDSignInButton import outside of conditional#591
Merged
Conversation
GIDSignInButton already gates internally for the proper OS, and gating in the umbrella header is causing build warnings in Xcode Supersedes google#342
Contributor
Author
|
Hey @w-goog - I opened this PR myself since the other one is from 2023. Would appreciate a merge, I signed the CLA a while back. Thanks! |
w-goog
approved these changes
Mar 5, 2026
w-goog
left a comment
w-goog
left a comment
Contributor
There was a problem hiding this comment.
Thank you! Love getting a warning cleaned up :) I've checked and it doesn't look like SPM or pods includes this explicitly in header search paths, so this should be good to go.
Closed
Contributor
Author
|
Any chance to get a release cut with this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GIDSignInButton already gates internally for the proper OS, and gating in the umbrella header is causing build warnings in Xcode
Supersedes #342