[bot] Merge master/807d8291 into rel/dev#1691
Conversation
The pattern used for the condition waiting was not robust enough and was susceptible to a race condition. This prevents that class of race condition by persisting the status and checking it when the signal is received, rather then relying on the assumption the notification always happens after all the relevant waiters are ready to receive it. JIRA: CQ-2677 risk: low
Move the call_finalizer_middleware before the lock acquisition. In case it fails, it no longer does so holding (and not releasing) the lock. There is nothing in the call_finalizer_middleware itself that would need the lock to be held. JIRA: CQ-2677 risk: low
fix: handle condition waiting better in thread_task_executor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1691 +/- ##
========================================
Coverage 78.02% 78.02%
========================================
Files 271 271
Lines 18637 18639 +2
========================================
+ Hits 14542 14544 +2
Misses 4095 4095 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
🚀 Automated PR to perform merge from master into rel/dev with changes up to 807d829 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/29494208573).