Remove default 60s command timeout#3
Open
jgowdy-godaddy wants to merge 2 commits into
Open
Conversation
The default timeout of 60s silently kills long-running commands like daemon processes. Commands that want a timeout can still pass --timeout explicitly; the framework should not impose one by default.
Sync the script file to disk before setting permissions and executing. On Linux, std::fs::write can return before the kernel finishes flushing the inode, causing ETXTBSY when the test immediately tries to exec the script.
jgowdy-godaddy
force-pushed
the
remove-default-timeout
branch
from
ce0a81b to
05240d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--timeoutwas60s, meaning every command had an implicit 60-second deadline0s(no timeout) — commands that want a deadline can still pass--timeout 60sexplicitlyContext
This caused gocode-dev's
secret-agentdaemon to die after exactly 60 seconds on every invocation after the cli-engine integration, triggering repeated Touch ID prompts as the agent respawned fresh each time.Test plan
cargo fmt --all --checkcleancargo clippy --workspace --all-targets -- -D warningsclean