docs(report): engine_transplant_claim_deferred also counts a reap retry or landing that finds the claim set (celeris#780) - #453
Draft
FumingPower3925 wants to merge 1 commit into
Draft
FumingPower3925 wants to merge 1 commit into
FumingPower3925 wants to merge 1 commit into
Conversation
…ry or landing that finds the claim set (celeris#780) celeris#765 (celeris#758) widened TransplantClaimDeferred: rerunHandOff, for a reap's retry or its landing, counts it too when it finds the dispatch goroutine's claim set. The Counts string still gave only the old meaning, a completion landing between the park and the drain. No gate reads the counter; this is the recorded description only.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
celeris#765 (celeris#758) widened celeris's
TransplantClaimDeferred.rerunHandOff, run for a reap's retry or its landing, now also counts it when it finds the dispatch goroutine's own hand-off claim set. celeris's docs (engine/engine.go,engine/iouring/handoff_loss.go) say so. TheCountsstring forengine_transplant_claim_deferredinreport/engine_counter.gostill gave only the old meaning: "a completion of the connection landed between the goroutine's park and the worker's drain of the claim".This PR is item 2's probatorium half of goceleris/celeris#780. The celeris half is goceleris/celeris#799.
Change
One string: "a hand-off attempt (a completion of the connection, a reap retry or a reap landing) found the claim set between the goroutine's park and the worker's drain of it (celeris#758, #780)". No gate reads this counter; probatorium only records it (
Series: false), so nothing else changes.Checks
gofmt,go vet ./report/,go test ./report/: clean.