Update examples for Goa v3.32.0 - #221
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update all 19 example modules from Goa v3.31.1 to the published v3.32.0 release and regenerate with the matching command. Regeneration changes only the 18
gen/goa.jsonversion markers; the API designs, handwritten implementations, and generated Go code are unchanged.The full preparation also updates gRPC from v1.83.2 to v1.84.0, refreshes Google RPC definitions and Smithy where used, advances tracing's basic-example dependency, and tidies module and workspace checksums. The final tidy adds
go-internalas an indirect requirement where needed.The examples retain their Go 1.26 minimum. CI now tests Go 1.26.8 and 1.27.1 explicitly with
GOTOOLCHAIN=local, so each selected toolchain must compile the examples itself. Review the module changes, generated version markers, and.github/workflows/ci.yamltogether.The root Makefile owns the version update for every module, then invokes each example's generation, lint, and tests. Tracing uses its existing test-only target because it has no local design.
make GOA_VERSION=v3.32.0passed across all 19 modules on Go 1.27.1, including the existing formatting and Staticcheck checks. Each module independently selects v3.32.0 with the published checksum and no Goa replacement. The full diff also passesgit diff --check. Hosted checks on both CI toolchains remain pending.No data migration or coordinated deployment is required. Existing callers send the same requests and receive the same designed results and errors. Consumers should update the Goa module and command together, regenerate, and test their application. Rollback restores the prior dependencies and generated output together.