refactor: tests - #3038
Draft
pd93 wants to merge 6 commits into
Draft
refactor: tests#3038pd93 wants to merge 6 commits into
pd93 wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to tidy up the ever increasing
task_test.gofile and its various testing methodologies. This work was started a long time ago but stalled due to the vast volume of tests that needed migrating.To reduce the immense amount of time this migration would take by hand, this PR was largely written using Claude Sonet 5. The agent was given the following goals across several independent prompt:
task_test.go. The end result should contain helper functions, setup and functional options boilerplate only. No actual functional tests.Executorshould useNewExecutorTestwhere possible. Anything that uses this setup will generate a fixture file with the expected output of that test. Tests that are not appropriate to this style of test may use another approach when necessary.fileContestTestentirelytask_test.goThis PR will remain in draft until I fully review all the tests to ensure that nothing has been clobbered. All the tests pass, but they need checking to ensure they still test the
Executorcorrectly.Checklist