Skip to content

go.mod: Upgrade go min version to 1.18#1260

Open
lvjp wants to merge 1 commit into
go-kit:masterfrom
lvjp:feature/go1.18
Open

go.mod: Upgrade go min version to 1.18#1260
lvjp wants to merge 1 commit into
go-kit:masterfrom
lvjp:feature/go1.18

Conversation

@lvjp

@lvjp lvjp commented Apr 30, 2023

Copy link
Copy Markdown

This will permit to use generics in future merge requests

@peterbourgon

Copy link
Copy Markdown
Member

Can we actually just make this 1.20 and 1.19?

@alwismt

alwismt commented May 5, 2023

Copy link
Copy Markdown

What about upgrade to least 1.19

@lvjp

lvjp commented May 11, 2023

Copy link
Copy Markdown
Author

If we upgrade to 1.19, tests will work correctly but the 1.20 test will fail.

If we upgrade to 1.20, tests will also fail !

@peterbourgon

Copy link
Copy Markdown
Member

Why do we think these failures are a function of the Go version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants